[bisq-network/bisq] Handle #2659, no output for asset fee tx (#2664)

[sqrrm]

sqrrm commented on this pull request.



> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
 
     public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
             throws WalletException, InsufficientMoneyException, TransactionVerificationException {
-        return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+        return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);

Indeed, it's almost impossible to make the burn fee match mining fee and completely spend the remaining BSQ in an output. I had to write some code just to make that happen.

Since there is an output (the opReturn) I think the tx might even be standard. I thought that wasn't the case at first but reading up I can't find anything saying otherwise. Best not merge this PR then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2664#discussion_r272830769
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190407/b7e8004d/attachment.html>