[bisq-network/bisq] Protect against late blind vote publishing (#2667)
sqrrm
notifications at github.com
Sun Apr 7 12:34:24 UTC 2019
sqrrm approved this pull request.
utACK
This might be a better way than using the date, but I don't have a really good model in my head so I'm not saying this with conviction.
> } else {
log.warn("We received an invalid blindVotePayload. blindVoteTxId={}", txId);
}
}
}
}
+
+ private boolean isInCorrectPhase(int blockHeight) {
It would be better to just call this `notInRevealPhase` or `isAcceptingProposals` to better describe what it does.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2667#pullrequestreview-223580062
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190407/273be17a/attachment.html>
More information about the bisq-github
mailing list