[bisq-network/bisq] Handle #2659, no output for asset fee tx (#2664)

[sqrrm]

sqrrm commented on this pull request.



> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
 
     public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
             throws WalletException, InsufficientMoneyException, TransactionVerificationException {
-        return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+        return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);

About your comments, the difference between `completePreparedProposalTx` and `completePreparedBsqTx` is the reimbursement option so they should work the same for non reimbursement proposals except that `completePreparedBsqTx` also handles the no output case. I think we have a bit of a problem with too much copy pasted code here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2664#discussion_r272832831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190407/bc5fb650/attachment.html>