[bisq-network/bisq] Handle #2659, no output for asset fee tx (#2664)

Manfred Karrer notifications at github.com
Sun Apr 7 14:12:25 UTC 2019

ManfredKarrer commented on this pull request.

> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
     public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
             throws WalletException, InsufficientMoneyException, TransactionVerificationException {
-        return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+        return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);

Yes I agree, the code need to be cleaned up and refactored, I am just too scary to do that now. Needs much care and testing. I prefer to focus on issues which are consensus relevant as there we cannot change later anymore (or it becomes much harder). 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190407/a6d866a3/attachment.html>

More information about the bisq-github mailing list