[bisq-network/bisq] Improve space management in button bar of overlays (#2699)

Manfred Karrer notifications at github.com
Thu Apr 11 17:21:44 UTC 2019

ManfredKarrer commented on this pull request.

> @@ -127,8 +127,7 @@ protected void onShow() {
     protected void addButtons() {
-        closeButton.setPrefWidth(162);
-        actionButton.setPrefWidth(162);
+        closeButton.prefWidthProperty().bind(actionButton.widthProperty());

Are you sure the setters are never called in any other popup? It would cause an error if binding is set and we call setWidth somewhere else....

Ah its not in the super class, so should be isolated then to that window.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190411/5143cd90/attachment.html>

More information about the bisq-github mailing list