[bisq-network/bisq] Use different security deposit for fiat-crypto and crypto-crypto trades (#2742)

sqrrm notifications at github.com
Thu Apr 18 21:09:21 UTC 2019


sqrrm approved this pull request.

utACK

As a reviewer I prefer when the previous commits are kept and just add a new one rather than a force push. Easier to follow which changes were made after comments were made that way.

> @@ -47,6 +47,8 @@
 
 import javax.annotation.Nullable;
 
+import static bisq.core.btc.wallet.Restrictions.getDefaultBuyerSecurityDepositAsPercent;

More static imports, in case you meant to revert them all, otherwise it's ok, just feels a bit excessive for these kinds of use cases.

>  import bisq.core.util.BSFormatter;
 
 import javax.inject.Inject;
 
+import static bisq.core.btc.wallet.Restrictions.getMaxBuyerSecurityDepositAsPercent;
+import static bisq.core.btc.wallet.Restrictions.getMinBuyerSecurityDepositAsPercent;

More static imports

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2742#pullrequestreview-228505978
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190418/b1e49fca/attachment.html>


More information about the bisq-github mailing list