[bisq-network/bisq] add Right-to-Left support (#2774)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - based on my inline comments. These required changes could be easily implemented, but I recognized that there are some issues with the tabs and toggle buttons we are using.

<img width="1312" alt="Bildschirmfoto 2019-04-25 um 14 28 45" src="https://user-images.githubusercontent.com/170962/56736027-5c56de00-6767-11e9-87e3-b780983cb36f.png">
Tab labels are squashed and hardly readable and the toggle is slightly misplaced and squashed as well. I'll see if I update the library if the problems were fixed already within newer versions.

> @@ -84,6 +84,12 @@
             */
     );
 
+    public static final List<String> rtlLanguagesCodes = Arrays.asList(

Can be private

> @@ -167,6 +169,8 @@ public MainView(MainViewModel model,
     @Override
     protected void initialize() {
         MainView.rootContainer = root;
+        if (LanguageUtil.isDefaultLanguageRTL())
+	    MainView.rootContainer.setNodeOrientation(NodeOrientation.RIGHT_TO_LEFT);

Please apply Bisq coding conventions and style guide: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#style-and-coding-conventions

> @@ -165,6 +165,9 @@ bg color of non edit textFields: fafafa
     -fx-selection-bar-non-focused: -fx-selection-bar;
 
     -fx-font-size: 13;
+}
+
+.root:dir(ltr){

Why was this necessary?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2774#pullrequestreview-230612058
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190425/407fc020/attachment.html>