[bisq-network/bisq] Backup, restore and create a new onion address via GUI (#3044)
Florian Reimair
notifications at github.com
Thu Aug 1 11:40:02 UTC 2019
This PR adds features that allow the user to
- backup her current onion address,
- restore a previously onion address backup
- and even create a completely new onion address
all from within the GUI.
**How do you make sure that there are no more open offers or even ongoing trades before you import/renew the address?**
I don't. I have reworked the P2P backend so that a single client can have multiple hidden services up and running at any time. If the user renews/imports an onion address, a new hidden service is started. Hidden services are only removed once no more open offers or ongoing trades are there (checked for after every completed trade/closed offer).
**All during runtime?**
No. A restart is required for the import and renew features.
Contains DE translations as well.
Here are some impressions:
![Screenshot from 2019-08-01 13-28-50](https://user-images.githubusercontent.com/1070734/62289942-56f0ea00-b460-11e9-86b7-8bd5dc91324e.png)
![Screenshot from 2019-08-01 13-29-57](https://user-images.githubusercontent.com/1070734/62289997-81db3e00-b460-11e9-83b7-f5ed12f731a6.png)
![Screenshot from 2019-07-30 12-09-40](https://user-images.githubusercontent.com/1070734/62289802-f792da00-b45f-11e9-954f-19752da0742d.png)
closes #1055, closes #1056, subsequently closes #909 and does take care of a lot of preparation work for #2873.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3044
-- Commit Summary --
* Gui mockup
* Refactored starting Tor
* Removed double assignment of nodeAddressProperty
* Remove unnecessary field
* Migrate to new folder structure of HSs
* Only report HSready when all HS are started
* Report TorNode ready once we now our address
* Formatting cosmetics
* Renew address is active
* Added clearHS stub
* First-time launch of Bisq works again
* Report unused HS on trade/offer close
* Report HS in use instead of unused ones
* Clear unused hidden services
* Reenable rolling backup
* Add informative popup before renew
* HS backup active
* HS restore active
* DE translations
* Handle duplicate hidden service situation
-- File Changes --
M core/src/main/java/bisq/core/offer/OpenOfferManager.java (20)
M core/src/main/java/bisq/core/trade/TradeManager.java (9)
M core/src/main/resources/i18n/displayStrings.properties (9)
M core/src/main/resources/i18n/displayStrings_de.properties (9)
M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (6)
M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.fxml (13)
M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (53)
M monitor/src/main/java/bisq/monitor/AvailableTor.java (4)
M p2p/src/main/java/bisq/network/p2p/P2PService.java (37)
M p2p/src/main/java/bisq/network/p2p/network/LocalhostNetworkNode.java (22)
M p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java (15)
M p2p/src/main/java/bisq/network/p2p/network/NewTor.java (4)
M p2p/src/main/java/bisq/network/p2p/network/RunningTor.java (4)
M p2p/src/main/java/bisq/network/p2p/network/TorMode.java (4)
M p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java (325)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3044.patch
https://github.com/bisq-network/bisq/pull/3044.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190801/c5be89ac/attachment-0001.html>
More information about the bisq-github
mailing list