[bisq-network/bisq] Test guice setup and fix (#3043)

Christoph Sturm notifications at github.com
Thu Aug 1 14:22:30 UTC 2019


christophsturm commented on this pull request.



> @@ -97,6 +97,7 @@ public String toString() {
 
     @Inject
     public KeyStorage(@Named(KEY_STORAGE_DIR) File storageDir) {
+        storageDir.mkdirs();

the CI error came from a missing key directory on CI. I now changed the keystorage to create the directory if its missing. not sure if that has any downsides. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3043#pullrequestreview-269654013
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190801/f616071d/attachment-0001.html>


More information about the bisq-github mailing list