[bisq-network/bisq] Field "Amount in USD to spend" is not working properly. (#3050)

[fresheneesz]

Scenario 1:

1. Create a new offer to buy bitcoin for dollars
2. Put $600 in the "Amount in USD to spend" field
3. Set the "Below % from market price" field to 2%

Result: The "Amount in USD to spend" has been changed to $588.
Expected: The "Amount in USD to spend" should remain $600. 

Scenario 2:

1. Create a new offer to buy bitcoin for dollars
2. Put $600 in the "Amount in USD to spend" field
3. Set the "Fixed price in USD for 1 BTC" field to $100

Result: The "Amount in USD to spend" has been changed to $50.
Expected: The "Amount in USD to spend" should remain $600.

Scenario 3:

1. Create a new offer to buy bitcoin for dollars
2. Put 0.5 BTC in the "Amount of BTC to buy" field
3. Set the "Fixed price in USD for 1 BTC" field to $1000.  The "Amount in USD to spend" field will be updated to read $500.
4. Put $600 in the "Amount in USD to spend" field

Result: The "Amount in USD to spend" field will revert to reading $500.
Expected: The "Amount in USD to spend" field will revert to reading $600 - the number you input. 

Note that this behavior doesn't happen for all inputs. For example, if you delete a 0 in $500, it will update to $50.00. If you put in $50 it will revert. If you put in $50.00 it *won't* revert. The logic on this field is VERY broken. Please don't just try fixing this bug with a patchover. The code obviously needs refactoring so the logic is cleaner.

Scenario 4:

1. Create a new offer to buy bitcoin for dollars
2. Put $600 in the "Amount in USD to spend" field
3. Put 0.05 BTC in the "Amount of BTC to buy" field

Result: The "Fixed price in USD for 1 BTC" or "Below % from market price" remain empty.
Expected: The "Fixed price in USD for 1 BTC" or "Below % from market price" should be updated so the equation is fulfilled (just like the  "Amount in USD to spend" field).

These fields just don't work intuitively or even correctly. Updating one part of the equation should update other parts of the equation, but it should anchor on the values the USER input, not on an arbitrary field. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3050
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190802/5d4aa47d/attachment.html>