[bisq-network/bisq-website] Add RSS feed hyperlink (#198)

Steve Jain notifications at github.com
Mon Aug 5 16:39:19 UTC 2019


m52go requested changes on this pull request.

@huey735 sorry I should've been more specific. I'd prefer to see CSS markup kept separate from HTML markup. I suggested HTML changes in-line. Here is the accompanying CSS markup:

```
.rss-link {
    float: right;
    width: 30px;
    height: auto;
}

.rss-link img {
    width: 100%;
}

.rss-link.blog-index {
    margin-top: 9px;
}

.rss-link.post {
    margin-top: 4px;
}

.post.type-post .dets h2, h1#blog-index-header {
    padding-right: 50px;
}
```

If you accept my HTML suggestions and add this markup to `css/styles.css` (ideally in the section marked 'blog/ after line 707), it should be good.

> @@ -5,6 +5,7 @@
   <article id="post-802" class="post-802 post type-post status-publish format-standard hentry category-news">
     <div class="dets_wrap">
       <div class="dets">
+        <a href="{{ site.url }}/blog/feed.atom" style="display: inline-block; float: right; margin-top: 4px;"><img src="{{ site.url}}/images/logo-rss.svg" class="rounded float-right" style="width: 30px;"></a>

```suggestion
       <a href="{{ site.url }}/blog/feed.atom" class="rss-link post"><img src="{{ site.url}}/images/logo-rss.svg"></a>
```

> @@ -2,7 +2,7 @@
 layout: page
 title: Blog ‹ Bisq - The decentralized Bitcoin exchange
 ---
-
+<a href="{{ site.url }}/blog/feed.atom" style="display: inline-block; float: right; margin-top: 9px;"><img src="{{ site.url}}/images/logo-rss.svg" class="rounded float-right" style="width: 30px;"></a>

```suggestion
<a href="{{ site.url }}/blog/feed.atom" class="rss-link blog-index"><img src="{{ site.url}}/images/logo-rss.svg"></a>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/198#pullrequestreview-270877155
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190805/e9245fea/attachment-0001.html>


More information about the bisq-github mailing list