[bisq-network/bisq] WIP show strange guice behavior (#3057)

Christoph Sturm notifications at github.com
Mon Aug 5 21:11:39 UTC 2019

Can anybody explain this? why does bisq.seednode.GuiceSetupTest work even when the OfferBook registration is commented out?

@ManfredKarrer @ripcurlx @sqrrm @freimair 
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * bump guice version and start testing desktop guice setup
  * why does this work? the test should fail because OfferBook is not registered

-- File Changes --

    M build.gradle (2)
    M desktop/src/main/java/bisq/desktop/DesktopModule.java (3)
    A desktop/src/test/java/bisq/desktop/GuiceSetupTest.java (31)
    M gradle/witness/gradle-witness.gradle (1)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190805/4e7a6e9e/attachment.html>

More information about the bisq-github mailing list