[bisq-network/bisq] use singleton annotation instead of binding as singleton (#3058)

[Christoph Sturm]

this is the correct way to do it. the way it is currently done means
that if a component is not declared in a module, guice still finds it
but does not use the singleton lifecycle

binding as singleton in the module is meant to be used for classes that
we don't have the sourcecode for (i.e. jdk classes)

also update guice because the current version has some incompatibilites with our asm lib and outputs internal errors when the wiring fails. 

this pr only converts the components that were declared in the desktop module. will convert the others later. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3058

-- Commit Summary --

  * bump guice version and start testing desktop guice setup
  * don't fail if there is no shutdown hook.
  * use singleton annotation instead of binding as singleton.
  * update witness file for new guice version

-- File Changes --

    M build.gradle (2)
    M core/src/main/java/bisq/core/util/BSFormatter.java (2)
    M core/src/main/java/bisq/core/util/BsqFormatter.java (2)
    M desktop/src/main/java/bisq/desktop/DesktopModule.java (36)
    M desktop/src/main/java/bisq/desktop/Navigation.java (3)
    M desktop/src/main/java/bisq/desktop/common/fxml/FxmlViewLoader.java (2)
    M desktop/src/main/java/bisq/desktop/common/view/CachingViewLoader.java (2)
    M desktop/src/main/java/bisq/desktop/common/view/guice/InjectorViewFactory.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DisplayedTransactionsFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TradableRepository.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradableFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionListItemFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/notifications/NotificationCenter.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TorNetworkSettingsWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/presentation/DaoPresentation.java (2)
    M desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java (2)
    M desktop/src/main/java/bisq/desktop/util/Transitions.java (2)
    A desktop/src/test/java/bisq/desktop/GuiceSetupTest.java (73)
    M gradle/witness/gradle-witness.gradle (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3058.patch
https://github.com/bisq-network/bisq/pull/3058.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3058
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190806/0e364ed2/attachment-0001.html>