[bisq-network/bisq] use singleton annotation instead of binding as singleton (#3058)

[mrosseel]

Is there a way to detect these 'orphan' classes which are automatically
wired by guice? Breaking the build would be better because even annotations
can be forgotten.

On Wed, 7 Aug 2019, 10:04 Christoph Sturm, <notifications at github.com> wrote:

> definately the class, the class knows if its a singleton. also the problem
> is that even when the class is not defined in the module but still on the
> classpath it will be found by guice, but have the wrong lifecycle. doing it
> by annotation ensures that the lifecycle is always correct.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/pull/3058?email_source=notifications&email_token=AALFXXW7RCVOKSWTOR2ORUDQDJ6XZA5CNFSM4IJXZL3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3XSD4A#issuecomment-518988272>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AALFXXVK3UDABTELYJYRO7DQDJ6XZANCNFSM4IJXZL3A>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3058#issuecomment-518989616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190807/4f8d205b/attachment-0001.html>