[bisq-network/bisq] also fix singleton config for core module (#3061)

[Christoph Sturm]

follow up to #3058 that converts the core module too. 
and unit test it all
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3061

-- Commit Summary --

  * bump guice version and start testing desktop guice setup
  * don't fail if there is no shutdown hook.
  * use singleton annotation instead of binding as singleton.
  * update witness file for new guice version
  * convert some of the core config
  * more singletoning
  * even more singletoning
  * singletonify the rest of the core module

-- File Changes --

    M build.gradle (2)
    M common/src/main/java/bisq/common/ClockWatcher.java (3)
    M common/src/main/java/bisq/common/crypto/KeyRing.java (2)
    M common/src/main/java/bisq/common/crypto/KeyStorage.java (2)
    M common/src/main/java/bisq/common/storage/CorruptedDatabaseFilesHandler.java (2)
    M core/src/main/java/bisq/core/CoreModule.java (51)
    M core/src/main/java/bisq/core/app/AvoidStandbyModeService.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (2)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (2)
    M core/src/main/java/bisq/core/app/TorSetup.java (2)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
    M core/src/main/java/bisq/core/network/p2p/seed/DefaultSeedNodeRepository.java (2)
    M core/src/main/java/bisq/core/notifications/MobileModel.java (2)
    M core/src/main/java/bisq/core/notifications/MobileNotificationService.java (2)
    M core/src/main/java/bisq/core/notifications/MobileNotificationValidator.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/DisputeMsgEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/MyOfferTakenEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java (2)
    M core/src/main/java/bisq/core/payment/TradeLimits.java (2)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (2)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/user/Preferences.java (4)
    M core/src/main/java/bisq/core/user/User.java (2)
    M core/src/main/java/bisq/core/util/BSFormatter.java (2)
    M core/src/main/java/bisq/core/util/BsqFormatter.java (2)
    M desktop/src/main/java/bisq/desktop/DesktopModule.java (36)
    M desktop/src/main/java/bisq/desktop/Navigation.java (3)
    M desktop/src/main/java/bisq/desktop/common/fxml/FxmlViewLoader.java (2)
    M desktop/src/main/java/bisq/desktop/common/view/CachingViewLoader.java (2)
    M desktop/src/main/java/bisq/desktop/common/view/guice/InjectorViewFactory.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DisplayedTransactionsFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TradableRepository.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradableFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionListItemFactory.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/notifications/NotificationCenter.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TorNetworkSettingsWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/presentation/DaoPresentation.java (2)
    M desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java (2)
    M desktop/src/main/java/bisq/desktop/util/Transitions.java (2)
    A desktop/src/test/java/bisq/desktop/GuiceSetupTest.java (133)
    M gradle/witness/gradle-witness.gradle (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3061.patch
https://github.com/bisq-network/bisq/pull/3061.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3061
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190807/05bfe910/attachment-0001.html>