[bisq-network/bisq] use singleton annotation instead of binding as singleton (#3058)

[Bernard Labno]

blabno approved this pull request.

The code looks good. 
I see pros and cons in both approaches. Just as forgetting to configure class as singleton in a module you can forget about annotating the class. Defining life cycle inside module allows for class reuse in different context, but that's very theoretical benefit.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3058#pullrequestreview-271924592
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190807/a369b463/attachment.html>