[bisq-network/bisq] also fix singleton config for core module (#3061)

[sqrrm]

sqrrm requested changes on this pull request.

Please fix the missing singleton

> @@ -118,15 +84,6 @@ protected void configure() {
         String referralId = environment.getProperty(AppOptionKeys.REFERRAL_ID, String.class, "");
         bind(String.class).annotatedWith(Names.named(AppOptionKeys.REFERRAL_ID)).toInstance(referralId);
 
-        bind(MobileNotificationService.class).in(Singleton.class);
-        bind(MobileMessageEncryption.class).in(Singleton.class);

MobileMessageEncryption doesn't have singleton annotation and not tested in GuiceSetupTest.java

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3061#pullrequestreview-274279464
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190813/3aed7844/attachment.html>