[bisq-network/bisq] fix build on jdk11 and jdk12. remove powermock and jmockit (#3081)

[Christoph Sturm]

the app still throws a NPE at startup, on jdk 12, but runs fine on jdk11
build and test suite works on jdk10,11,12

had to disable a very small amount of tests that were not so easy to convert. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3081

-- Commit Summary --

  * WIP remove powermock
  * remove powermock from core.
  * remove more powermock and jmockit tests.
  * remove powermock from gradle file
  * remove jmockit

-- File Changes --

    M build.gradle (28)
    M core/src/main/java/bisq/core/dao/governance/period/PeriodService.java (2)
    M core/src/main/java/bisq/core/offer/OfferPayload.java (2)
    M core/src/main/java/bisq/core/user/Preferences.java (2)
    M core/src/test/java/bisq/core/arbitration/ArbitratorManagerTest.java (13)
    M core/src/test/java/bisq/core/btc/TxFeeEstimationServiceTest.java (5)
    M core/src/test/java/bisq/core/btc/nodes/BtcNodesSetupPreferencesTest.java (8)
    M core/src/test/java/bisq/core/dao/governance/ballot/BallotListServiceTest.java (6)
    M core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java (47)
    M core/src/test/java/bisq/core/dao/state/DaoStateSnapshotServiceTest.java (10)
    M core/src/test/java/bisq/core/offer/OfferTest.java (8)
    M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (8)
    M core/src/test/java/bisq/core/payment/PaymentAccountsTest.java (8)
    M core/src/test/java/bisq/core/payment/ReceiptPredicatesTest.java (8)
    M core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java (9)
    M core/src/test/java/bisq/core/payment/TradeLimitsTest.java (6)
    M core/src/test/java/bisq/core/trade/TradableListTest.java (9)
    M core/src/test/java/bisq/core/user/PreferencesTest.java (8)
    A core/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker (1)
    A desktop/src/main/java/bisq/desktop/main/offer/MakerFeeMaker.java (13)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (7)
    M desktop/src/test/java/bisq/desktop/main/funds/transactions/TransactionAwareTradeTest.java (9)
    M desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java (8)
    M desktop/src/test/java/bisq/desktop/main/market/spread/SpreadViewModelTest.java (8)
    M desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java (33)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModelTest.java (27)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java (14)
    M desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java (8)
    M desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java (14)
    M desktop/src/test/java/bisq/desktop/main/settings/preferences/PreferencesViewModelTest.java (8)
    M desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java (8)
    M desktop/src/test/java/bisq/desktop/util/CurrencyListTest.java (8)
    M desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java (26)
    A desktop/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker (1)
    M p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageTest.java (24)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3081.patch
https://github.com/bisq-network/bisq/pull/3081.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190813/4416572e/attachment-0001.html>