[bisq-network/bisq] inject publickeyring (#3086)

[Manfred Karrer]

ManfredKarrer requested changes on this pull request.

NACK

See comment for missing final.

I will review again after rebase with other PR is done.

> @@ -96,6 +98,7 @@ protected void configure() {
         install(alertModule());
         install(filterModule());
         install(corePresentationModule());
+        bind(PubKeyRing.class).toProvider(PubKeyRingProvider.class);

Is this guaranteed to be in singleton context?
Can you move it to the other bindings above, so th einstall calls are not mixed with bind calls?

> @@ -96,6 +98,7 @@ protected void configure() {
         install(alertModule());
         install(filterModule());
         install(corePresentationModule());
+        bind(PubKeyRing.class).toProvider(PubKeyRingProvider.class);

Ah from the test below its seems its singleton.

> @@ -42,7 +42,7 @@
 @Slf4j
 @EqualsAndHashCode
 @Getter
-public final class PubKeyRing implements NetworkPayload, UsedForTradeContractJson {
+public class PubKeyRing implements NetworkPayload, UsedForTradeContractJson {

Might be used in p2p messages so must be final. I know its prob. not used now but further refactoring might use it... all NetworkPayload classes should be final.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3086#pullrequestreview-274983558
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190814/3f195943/attachment-0001.html>