[bisq-network/bisq] Gui layout tweaks (#3077)

Manfred Karrer notifications at github.com
Wed Aug 14 16:30:40 UTC 2019


ManfredKarrer requested changes on this pull request.

NACK. 
See comments

> @@ -173,7 +173,6 @@ protected void buildForm() {
 
         Tuple3<Label, ListView<PaymentAccount>, VBox> tuple = addTopLabelListView(root, gridRow, Res.get("account.altcoin.yourAltcoinAccounts"), Layout.FIRST_ROW_DISTANCE);
         paymentAccountsListView = tuple.second;
-        paymentAccountsListView.setPrefHeight(2 * Layout.LIST_ROW_HEIGHT + 14);
         setPaymentAccountsCellFactory();

By removing that it would require a min. height as otherwise the list can get truncated.
<img width="1202" alt="Screen Shot 2019-08-14 at 18 24 35" src="https://user-images.githubusercontent.com/1449498/63038237-fe3e3a00-bec0-11e9-8d6c-72ec727aef4c.png">


> @@ -173,7 +173,6 @@ protected void buildForm() {
 
         Tuple3<Label, ListView<PaymentAccount>, VBox> tuple = addTopLabelListView(root, gridRow, Res.get("account.altcoin.yourAltcoinAccounts"), Layout.FIRST_ROW_DISTANCE);
         paymentAccountsListView = tuple.second;
-        paymentAccountsListView.setPrefHeight(2 * Layout.LIST_ROW_HEIGHT + 14);
         setPaymentAccountsCellFactory();

paymentAccountsListView.setMinHeight(2 * Layout.LIST_ROW_HEIGHT + 14);
will do it.
Same on fiat account view

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3077#pullrequestreview-275004167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190814/5cc00307/attachment.html>


More information about the bisq-github mailing list