[bisq-network/bisq] Bump protobuf to fix annoying warnings (#3097)

battleofwizards notifications at github.com
Thu Aug 15 19:14:59 UTC 2019


Protobuf got updated to the latest released version 3.9.1. The main motivation was to fix the following annoying warnings:

```
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/home/qertoip/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java/3.5.1/8c3492f7662fa1cbf8ca76a0f5eb1146f7725acd/protobuf-java-3.5.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
```

I did some manual smoke tests by clicking through the bisq-desktop, for both new user and existing user with data.

PS There is still a similar warning for `guice` dependency, awaiting upstream fix.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3097

-- Commit Summary --

  * Bump protobuf to fix annoying warnings

-- File Changes --

    M build.gradle (2)
    M gradle/witness/gradle-witness.gradle (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3097.patch
https://github.com/bisq-network/bisq/pull/3097.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3097
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190815/2faa4c70/attachment.html>


More information about the bisq-github mailing list