[bisq-network/bisq] Define more version variables, fix style problems (#3092)

Stan notifications at github.com
Fri Aug 16 01:33:08 UTC 2019


> Nice little cleanup. Could you please rebase to a single, clean commit? Otherwise ACK (tested).
@battleofwizards ,

This PR is a continuation of [3052](https://github.com/bisq-network/bisq/pull/3052), created before I found out PR merges must come from topic branches, _not_ master forks.  After I made commits for that PR and waited for approval / merge, other commits were made on this file and I chased those, manually merging them to my master fork's build.gradle.

This Son of PR 3052 is also based on changes on that same master fork -- again, chasing others' commits to this file and doing the last bit of tidying up before re-forking and doing all work in topic branches from now on ;-/

I don't know how to rebase / squash commits on my master fork into a single commit.  I've never done it, and don't want to make a mess.

Do you think I should close this PR and create a new PR for merging from a _topic branch_ created from a new master fork?  Its build.gradle file will have one commit and no diffs from the one you just tested.  But if I do need to merge & tidy up others' commits while my new PR is still open, I will be able to squash those commits in the topic branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3092#issuecomment-521852551
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190815/b129c351/attachment.html>


More information about the bisq-github mailing list