[bisq-network/bisq] Various optimizations (#3112)

[Manfred Karrer]

ManfredKarrer requested changes on this pull request.

NACK

See comment

> @@ -55,7 +55,8 @@ public boolean areDataFieldsValid(Proposal proposal) {
             validateDataFields(proposal);
             return true;
         } catch (ProposalValidationException e) {
-            log.warn("proposal data fields are invalid. proposal={}, error={}", proposal, e.toString());
+            // TODO only log once dao state is complete
+            //log.warn("proposal data fields are invalid. proposal={}, error={}", proposal, e.toString());

That should be still used. The fix in the subclass avoids the wrong logs 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3112#pullrequestreview-277070482
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/3b806b4d/attachment.html>