[bisq-network/bisq] make sure that signed witness is immutable. (#3108)

[Manfred Karrer]

ManfredKarrer approved this pull request.

utACK

see Nit comment...

>  
+    @Test
+    public void isImmutable() {
+        byte[] signerPubkey = arbitrator1Key.getPubKey();
+        SignedWitness signedWitness = new SignedWitness(true, witnessHash, witnessHashSignature, signerPubkey, witnessOwner1PubKey, Instant.now().getEpochSecond(), 100);
+        byte[] witnessHash = signedWitness.getWitnessHash().clone();

Maybe better to use a different name? Now the this.witnessHash and witnessHash are different, which makes the test a bit harder to read IMO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3108#pullrequestreview-277076718
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/b1e51e2e/attachment.html>