[bisq-network/bisq] make sure that signed witness is immutable. (#3108)

Manfred Karrer notifications at github.com
Tue Aug 20 10:39:47 UTC 2019

ManfredKarrer approved this pull request.


see Nit comment...

+    @Test
+    public void isImmutable() {
+        byte[] signerPubkey = arbitrator1Key.getPubKey();
+        SignedWitness signedWitness = new SignedWitness(true, witnessHash, witnessHashSignature, signerPubkey, witnessOwner1PubKey, Instant.now().getEpochSecond(), 100);
+        byte[] witnessHash = signedWitness.getWitnessHash().clone();

Maybe better to use a different name? Now the this.witnessHash and witnessHash are different, which makes the test a bit harder to read IMO.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/b1e51e2e/attachment.html>

More information about the bisq-github mailing list