[bisq-network/bisq] Various optimizations (#3112)

Manfred Karrer notifications at github.com
Tue Aug 20 10:44:03 UTC 2019


ManfredKarrer commented on this pull request.



> @@ -55,7 +55,8 @@ public boolean areDataFieldsValid(Proposal proposal) {
             validateDataFields(proposal);
             return true;
         } catch (ProposalValidationException e) {
-            log.warn("proposal data fields are invalid. proposal={}, error={}", proposal, e.toString());
+            // TODO only log once dao state is complete
+            //log.warn("proposal data fields are invalid. proposal={}, error={}", proposal, e.toString());

Would have been better in a new commit so make it more transparent. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3112#discussion_r315622164
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/46cf3608/attachment.html>


More information about the bisq-github mailing list