[bisq-network/bisq] Backup, restore and create a new onion address via GUI (#3044)

[Florian Reimair]

freimair commented on this pull request.



> @@ -97,6 +98,8 @@
     private final P2PService p2PService;
     private final BtcWalletService btcWalletService;
     private final TradeWalletService tradeWalletService;
+    @Inject
+    private TradeManager tradeManager;

TradeManager and OpenOfferManager each have to know each other when instantiated. Even guice cannot resolve that. Having guice inject the TradeManager a tad later resolves the circular dependency and things work again. I am not happy with that, but that is the best we can do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#discussion_r315623688
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/e184e8ad/attachment-0001.html>