[bisq-network/bisq] [WIP] Backup, restore and create a new onion address via GUI (#3044)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> @@ -97,6 +98,8 @@
     private final P2PService p2PService;
     private final BtcWalletService btcWalletService;
     private final TradeWalletService tradeWalletService;
+    @Inject
+    private TradeManager tradeManager;

Oh ok. Please don't do that. We are just hiding a circular dependency that way and we should rather avoid it s it shows a wrong design.
I think in that case its anyway a code duplication issue and that should move out to probably a 3rd class. Need to look closer for more details...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#discussion_r315633436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/c99c1d15/attachment.html>