[bisq-network/bisq] [WIP] Backup, restore and create a new onion address via GUI (#3044)

[Florian Reimair]

freimair commented on this pull request.



> @@ -97,6 +98,8 @@
     private final P2PService p2PService;
     private final BtcWalletService btcWalletService;
     private final TradeWalletService tradeWalletService;
+    @Inject
+    private TradeManager tradeManager;

well, that it not so easy. It is definitely not solvable with best-practice Java. Here is some food-for-thought: 
![Screenshot from 2019-08-20 15-06-27](https://user-images.githubusercontent.com/1070734/63349721-472c3d80-c35c-11e9-8300-a2f417ca8a70.png)
(black is status, green works out of the box, red requires dependency, the grey thought experiment introduces 2 circular dependencies). All in all, some devilish trickery seems due.

Or: What if we only check for EOL hidden services on trade complete? Bisq is about trading and not about cancelling offers. The HS might live longer without being needed but does that hurt? Eventually a trade completes and thus, the HS is cleaned up.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#discussion_r315679361
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190820/196f2563/attachment.html>