[bisq-network/bisq] work on signed witness and convert unit test to kotlin (#3120)

Christoph Sturm notifications at github.com
Wed Aug 21 10:38:57 UTC 2019


based on #3111 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3120

-- Commit Summary --

  * Apply kotlin plugin and convert one unused class to kotlin
  * put version variables in alphabetical order.
  * convert SignedWitnessTest to kotlin, add mockito-kotlin
  * init signedWitnessService at declaration to make it a non null val
  * Inject P2PDataStorage instead of whole P2PService.
  * assert that all the account signing services are singletons

-- File Changes --

    M .idea/codeStyles/codeStyleConfig.xml (1)
    M build.gradle (9)
    M core/src/main/java/bisq/core/account/sign/SignedWitnessService.java (13)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitness.java (2)
    D core/src/test/java/bisq/core/account/sign/SignedWitnessServiceTest.java (284)
    A core/src/test/java/bisq/core/account/sign/SignedWitnessServiceTest.kt (277)
    M desktop/src/test/java/bisq/desktop/GuiceSetupTest.java (9)
    M gradle/witness/gradle-witness.gradle (8)
    M p2p/src/test/java/bisq/network/p2p/storage/ProtectedDataStorageTest.java (4)
    D p2p/src/test/java/bisq/network/p2p/storage/mocks/MockData.java (88)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/MockData.kt (39)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3120.patch
https://github.com/bisq-network/bisq/pull/3120.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3120
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190821/550e9c5f/attachment.html>


More information about the bisq-github mailing list