[bisq-network/bisq] Arbitrator to sign (#3121)

Christoph Sturm notifications at github.com
Wed Aug 21 16:12:29 UTC 2019


christophsturm commented on this pull request.



> +    }
+
+    // Arbitrator signing
+    public List<BuyerDataItem> getBuyerPaymentAccounts(long safeDate) {
+        return disputeManager.getDisputesAsObservableList().stream()
+                .filter(this::hasChargebackRisk)
+                .filter(this::isBuyerWinner)
+                .map(this::getBuyerData)
+                .filter(Objects::nonNull)
+                .filter(buyerDataItem -> buyerDataItem.getAccountAgeWitness().getDate() < safeDate)
+                .distinct()
+                .collect(Collectors.toList());
+    }
+
+    private boolean hasChargebackRisk(Dispute dispute) {
+        return PaymentMethod.hasChargebackRisk(dispute.getContract().getPaymentMethodId());

we should stop calling static util methods. Maybe we can move some methods from PaymentMethod to a class that we can inject. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3121#pullrequestreview-277909601
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190821/c50c6fb0/attachment.html>


More information about the bisq-github mailing list