[bisq-network/bisq-website] Update stats and download version (#204)

Steve Jain notifications at github.com
Wed Aug 21 19:23:41 UTC 2019

m52go requested changes on this pull request.

Agreed about the stats numbers—will remember this next time.

That `version` front-matter variable is not used...the `site.client_version` is the way this page gets the version number. I'll make a PR to remove it altogether. Then we won't have to worry about updating those files at all :)

+      <!-- Outdated translation tag-->
+      {% if page.lang == page.lang == "de" or page.lang="es" or "pt-PT" or page.lang == "zh-CN" %}

When is this "outdated translation" text supposed to show? This line seems to indicates it will show any time the current language is not EN (and indeed that's what happens when I run this locally).

Otherwise, please double-check the logic. `page.lang == page.lang` is redundant and you're missing the equality operator for ES (`page.lang="es"` needs `==`).

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190821/6d5e0e85/attachment-0001.html>

More information about the bisq-github mailing list