[bisq-network/bisq] Fix bugs in SearchComboBox (improve autocomplete) (#3124)

battleofwizards notifications at github.com
Wed Aug 21 20:28:32 UTC 2019


Bisq's `SearchComboBox` implements a simple autocomplete. It is used on the "add new altcoin account" form.

This fixes the following bugs in the `SearchComboBox`:

* no more dropdown flickering (fixed hide+show hack)
* space key no longer resets the text input
* unconfirmed changes no longer affect the form
* empty list no longer renders empty dropdown

This PR is the first step towards using autocomplete more widely in the project. Once merged I will attempt to address https://github.com/bisq-network/bisq/issues/2712 (but can't promise anything).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3124

-- Commit Summary --

  * Fix bugs in SearchComboBox (improve autocomplete)

-- File Changes --

    M desktop/src/main/java/bisq/desktop/components/SearchComboBox.java (122)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/AssetsForm.java (6)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3124.patch
https://github.com/bisq-network/bisq/pull/3124.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190821/3224e5f8/attachment.html>


More information about the bisq-github mailing list