[bisq-network/bisq] List Ndau (XND) (#3110)

Peter Goodspeed-Niklaus notifications at github.com
Fri Aug 23 14:46:12 UTC 2019


> I guess we would rather... have no full address validation rather than adding a new dependency.

If I were to use a regex validator, it would necessarily accept addresses which the actual validator would reject: you can't check internal hash codes with a regex. That said, I do not know what the actual effects would be if the bisq validator accepted addresses which are in fact invalid. If the consequences are acceptable, it would be easy to implement. 

Doing so will necessitate changing the test suite, many of the invalid cases of which are single-character replacements which invalidate the internal hash.

@battleofwizards would that be more palatable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3110#issuecomment-524343153
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190823/d4623f2b/attachment.html>


More information about the bisq-github mailing list