[bisq-network/bisq-website] Refactor font CSS to allow per-locale fonts, add Japanese font (#209)

Steve Jain notifications at github.com
Fri Aug 23 16:56:30 UTC 2019


m52go requested changes on this pull request.

Thanks for cleaning this! 

Small issue: the h1 on the front page needs the 200 weight version of the monospace font.

> @@ -23,693 +23,22 @@
         <meta property="twitter:site" content="Bisq - The decentralized Bitcoin exchange">
         <meta name="twitter:creator" content="@bisq_network">
         <link rel="canonical" href="{{ site.url }}{{ page.url }}">
+        {% if page.lang == "ja" %}
+        <link href="https://fonts.googleapis.com/css?family=M+PLUS+Rounded+1c" rel="stylesheet">
+        {% else %}
+        <link href="https://fonts.googleapis.com/css?family=IBM+Plex+Mono" rel="stylesheet">

```suggestion
        <link href="https://fonts.googleapis.com/css?family=IBM+Plex+Mono:200" rel="stylesheet">
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/209#pullrequestreview-279113420
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190823/fdcfcf26/attachment.html>


More information about the bisq-github mailing list