[bisq-network/bisq] Validate phone numbers (#3134)

[Stan]

ghubstan commented on this pull request.



> +    @Getter
+    private final String callingCode;
+    /**
+     * The normalized (digits only) representation of an international calling code.
+     */
+    private final String normalizedCallingCode;
+    /**
+     * Phone number in E.164 format.
+     */
+    @Nullable
+    @Getter
+    private String normalizedPhoneNumber;
+
+    // Hide no-arg constructor
+    private PhoneNumberValidator() {
+        this.isoCountryCode = null;

OK.  I thought all final instance variables had to be initialized in a constructor, and in this class, the no-arg constructor had to be hidden (private) to prevent another class from using it.  In the former case, maybe it was true in an earlier JDK?  In the latter, I'm still not sure it was a good idea to remove the private no-arg constructor, but I followed your advice anyway. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3134#discussion_r317363998
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190824/a1adf901/attachment.html>