[bisq-network/bisq] Validate phone numbers (#3134)

battleofwizards notifications at github.com
Sat Aug 24 20:21:13 UTC 2019

battleofwizards commented on this pull request.

> +    @Getter
+    private final String callingCode;
+    /**
+     * The normalized (digits only) representation of an international calling code.
+     */
+    private final String normalizedCallingCode;
+    /**
+     * Phone number in E.164 format.
+     */
+    @Nullable
+    @Getter
+    private String normalizedPhoneNumber;
+    // Hide no-arg constructor
+    private PhoneNumberValidator() {
+        this.isoCountryCode = null;

Sorry! I didn't mean to imply removing private constructor. I do agree it is important here.

So please either revert back to assigning nulls **or** simply get rid off the problematic final. In the context of clean code (small methods and classes) Java finals are overrated. They only protect the reference anyway and not the object's content.

Whatever you pick it will be OK with me.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190824/7c03d6cf/attachment.html>

More information about the bisq-github mailing list