[bisq-network/bisq] Bisq does not validate Bitcoin P2P node at configuration time (#3137)
notifications at github.com
Sun Aug 25 08:40:37 UTC 2019
[How to Reproduce]
1) Go to Settings -> Network
2) In the Bitcoin P2P node configuration under "use the following Bitcoin nodes", enter an invalid or unsupported hostname , such as the Tor v3 hostname 32zzibxmqi2ybxpqyggwwuwz7a3lbvtzoloti7cxoevyvijexvgsfeid.onion:8333
3) Bisq indicates it must be restarted, click OK
After Step 2, Bisq should validate the hostname is a valid Tor v2 hostname using regex or some other method, and also attempt to connect to this node. If it cannot validate or connect, it should not allow this setting to be changed, and it should not instruct the user to restart Bisq.
After Step 3, Bisq restarts, and despite the Bitcoin node being unreachable, the user should be able to proceed and reconfigure their settings to a reachable Bitcoin node.
After Step 2, Bisq did not perform any validation or testing of the user-entered hostname, it allowed the user the proceed, and it requested the user to proceed and restart Bisq.
After Step 3, Bisq restarts, but because the node is unreachable the following error is displayed and user is stuck with no way to correct their Bitcoin node settings, as they cannot get to the configuration screen.
<img width="996" alt="Screen Shot 2019-08-25 at 16 38 49" src="https://user-images.githubusercontent.com/232186/63647636-36663800-c75f-11e9-9b28-ecf43f89d31e.png">
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github