[bisq-network/bisq] Changed "Portfolio" to "Orders" (#3136)

Manfred Karrer notifications at github.com
Sun Aug 25 10:34:15 UTC 2019


ManfredKarrer requested changes on this pull request.

NACK
Trades are not orders and we intentionally do not use the domain language from centralized exchanged where orders get executed by a matching engine. Bisq does not work like that. Also what you edited is not the app code but a demo class as the name suggests.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3136#pullrequestreview-279329459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190825/72df502f/attachment.html>


More information about the bisq-github mailing list