[bisq-network/bisq-website] Add French translation (#213)

Steve Jain notifications at github.com
Mon Aug 26 14:41:20 UTC 2019


> My idea is to add or remove "page.lang == langcode" depending on what is what's not up to date.

Ah, I see now. Generally it's bad practice to edit code to achieve that kind of functionality. Rather, it's better to structure the code so that changes can be made in the "front end" (in this case, through Liquid page variables). 

Another benefit of this approach: by using page variables, you could mark specific pages as outdated. Right now, with this approach, marking a language as outdated makes it outdated through the whole site, even if it's just one page that needs updates.

> I thought that in order to do two concurrent but separate PRs I needed to work on two different branches but that doesn't seem like the case. I guess I need to work on different forks.

No worries. You can make as many branches as you want :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/213#issuecomment-524887814
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190826/13cc3a13/attachment.html>


More information about the bisq-github mailing list