[bisq-network/bisq] Validate phone numbers (#3134)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - based on my comments. Please update your PR with the required changes and I'll give it a spin 👍 

> @@ -804,6 +804,10 @@ bg color of non edit textFields: fafafa
     -fx-fill: -bs-rd-nav-deselected;
 }
 
+.nav-button-japanese .text {

Why is this change part of this PR? I think something got wrong during rebasing of your branch.

> @@ -809,6 +809,10 @@ private void setupBadge(JFXBadge buttonWithBadge, StringProperty badgeNumber, Bo
 
             this.setToggleGroup(navButtons);
             this.getStyleClass().add("nav-button");
+            // Japanese fonts are dense, increase top nav button text size

Why is this change part of this PR? I think something got wrong during rebasing of your branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3134#pullrequestreview-280006722
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190827/272a74a5/attachment.html>