[bisq-network/bisq] fix random test failure. (#3122)

Christoph Atteneder notifications at github.com
Tue Aug 27 08:01:03 UTC 2019


> I think its not ideal that the monitor does not use Guice, but in its manual wiring its still only creating one instance. also thats not really related to this fix.

I looked at the code again It is true that it shouldn't be a problem as the Guice autowiring is kind of overwritten in all used classes in that use-case by manual instantiation. So no matter if the Guice autowiring wins over the manual instantiation or the other way round it shouldn't cause any issues.

so utACK

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3122#issuecomment-525187892
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190827/1f661cd2/attachment.html>


More information about the bisq-github mailing list