[bisq-network/bisq] Arbitrator to sign (#3121)

[Christoph Sturm]

christophsturm commented on this pull request.



> @@ -131,6 +132,7 @@ public void testGuiceSetup() {
         assertSingleton(TradeEvents.class);
         assertSingleton(PriceAlert.class);
         assertSingleton(MarketAlerts.class);
+        assertSingleton(ChargeBackRisk.class);

ChargebackRisk is stateless so it does not need to be a singleton. of course it does not hurt to be a singleton, but I think guice best practice for stateless services is to keep them as default scope. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3121#pullrequestreview-280176503
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190827/6f93d8c0/attachment.html>