[bisq-network/bisq] Minimal api (#3001)

Bernard Labno notifications at github.com
Wed Aug 28 07:35:42 UTC 2019

Minimal Jetty dependencies are:
* org.eclipse.jetty:jetty-server
* javax.servlet:javax.servlet-api
* org.eclipse.jetty:jetty-http
* org.eclipse.jetty:jetty-io
* org.eclipse.jetty:jetty-util

Cutting out other deps will require us to:
* manually write swagger.json to document the API (keeping it in sync will be a challenge)
* write custom json serialization/deserialization (automatic gson is not enough)
* write custom error handling
* write custom validation
* write custom route handlers

That's a lot of additional effort.
Now, I've invested a lot of time into this work (started in early 2018). I had to rewrite many parts multiple times, because core was changing and core team was under resourced to give enough attention to this contribution.
So I'm not sure if there is any point in putting any more effort from my side into adding a lot of code to substitute current dependencies, just to learn that this work is not going to be merged.
I would like to get some serious response back from maintainers if the additional dependencies are the only concern and if I cut those dependencies down to those mentioned in the beginning of this post, will this PR be merged. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/c0993363/attachment.html>

More information about the bisq-github mailing list