[bisq-network/bisq] Dark Mode (#3152)

[wiz]

Sorry, I'm a bit confused. The intended scope of this PR is merely to implement Dark Mode in a way that doesn't add jar deps. I took the CSS code from @peterzen and already fixed the 12 or so major UI issues that were immediately visible to me. @ripcurlx could you clarify what action we are currently waiting from, and by whom?

Actually, could you please help to clarify my understanding and expectations about how the entire PR workflow and release process in Bisq DAO should work? Recently I am concerned about the "PR Limbo" problem - but first let me verify my current understanding:

1) This PR is still actively and currently assigned to @ripcurlx and @sqrrm for review, not @pedromvpg or anyone else. Since it seems neither reviewer has reviewed or tested the PR yet, the action we are currently waiting from is a review with comments from one of them. If the reviewer(s) wish to assign review to another person, they would do so with the "assign" feature in GitHub.

2) If @peterzen or @pedromvpg want to tweak the light/dark themes or other CSS code further, they are free to do so in their own separate PR(s) after this PR is merged, but they are not currently members of this PR and it is still only pending action from either reviewer.

3) I expect the reviewer(s) of the PR to actually review and test this PR by themselves, in addition to any outside reviewers assigned. If anyone finds issues with this PR, they should report them here and I will amend the PR if necessary. If there are no issues from the reviewers, they should proceed with merging.

4) When Devin and I do the full release testing this weekend for v1.1.6, if we find any major UI issues caused by this PR then we should either fix them at that time (again, as part of completely separate bugfix PRs) or we should revert this PR entirely to prevent those UI issues from making it into the v1.1.6 release.

If the above is correct, then can you please tell me why you haven't taken any action on this PR yet? Please understand that my intention is not to criticize any person or process, it's mainly to avoid PR limbo, after seeing some issues open for literally years on here I want to clarify who is actively assigned, and what the action is to take. Maybe we should make a flowchart for this workflow process?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3152#issuecomment-525671411
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/a841c84e/attachment.html>