[bisq-network/bisq] Dark Mode (#3152)

[Peter Banik]

> @wiz Thanks for taking over the dark mode handling. @peterzen waited very patiently already to get his changes into Bisq  . I do remember that a couple of color codes of the current version (light_version) weren't right, so someone needs to go through the app and have a look if everything looks as it did before, when light mode is selected.

I'm happy to see this moving towards being merged.

However, I have to say I'm a bit puzzled by the process - my PR was sitting idle for several months waiting on designer input to get a couple color codes straightened out and any comments/feedback  from other developers, which I was of course happily going to implement.  Instead of that happening, someone else creates another PR based on mine in a matter of hours and makes the changes directly.

No hard feelings and again, I'm happy that this is making its way into the release but this process does feel a little sour and unheard of in the open source projects I've contributed to so far.  (It's my first contribution to Bisq so of course it could just be my ignorance that I wasn't aware of some aspect of the PR review workflow, in which case I apologise for not being aware of it.)

@wiz @ripcurlx care to comment?  


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3152#issuecomment-525740082
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/281dddeb/attachment.html>