[bisq-network/bisq] Dark Mode (#3152)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - Please have a look at my comment on the data type of the UI theme property. I'll have a look at the css color codes next.

> @@ -1378,6 +1378,7 @@ message PreferencesPayload {
     int32 ignore_dust_threshold = 51;
     double buyer_security_deposit_as_percent_for_crypto = 52;
     int32 block_notify_port = 53;
+    bool use_dark_mode = 54;

I think it would be better to not use a boolean in case we'll add more color variations in the future (see https://github.com/bisq-network/bisq/pull/2414/files#diff-c8de125bfd3c56b7fa8f2bca445dd516)

> @@ -47,6 +48,10 @@ public static void setUseAnimations(boolean useAnimations) {
         GlobalSettings.useAnimations = useAnimations;
     }
 
+    public static void setUseDarkMode(boolean useDarkMode) {
+        GlobalSettings.useDarkMode = useDarkMode;

I don't think we need to store it in the GlobalSettings

> @@ -122,6 +122,8 @@
     @Getter
     private final BooleanProperty useAnimationsProperty = new SimpleBooleanProperty(prefPayload.isUseAnimations());
     @Getter
+    private final BooleanProperty useDarkModeProperty = new SimpleBooleanProperty(prefPayload.isUseDarkMode());

See my comment on the the data type of the ui theme above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3152#pullrequestreview-280864845
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/6997c70a/attachment.html>