[bisq-network/bisq] Dark Mode (#3152)

Peter Banik notifications at github.com
Wed Aug 28 15:22:39 UTC 2019


peterzen commented on this pull request.



> @@ -122,6 +122,8 @@
     @Getter
     private final BooleanProperty useAnimationsProperty = new SimpleBooleanProperty(prefPayload.isUseAnimations());
     @Getter
+    private final BooleanProperty useDarkModeProperty = new SimpleBooleanProperty(prefPayload.isUseDarkMode());

This code is outdated, as per your earlier review #2414 was changed from using a `bool` to a `UiTheme` object which allows for any number of themes: https://github.com/peterzen/bisq/blob/f35a0d58b2aef137b9b4fe9f37f27e78ce00f20c/common/src/main/proto/pb.proto#L1855

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3152#discussion_r318643931
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/ceceb576/attachment.html>


More information about the bisq-github mailing list