[bisq-network/bisq-website] [WIP] Refactored "Statistics" page to make it more i18n friendly (#221)

erciccione notifications at github.com
Thu Aug 29 11:02:53 UTC 2019

> The strings_en.yml must have the same keys/variables as the other languages' .yml files. 

I changed the logic behind the *Statistics* page to achive this. Now a snippet is included in all `stats.html` files which will call `includes/statistic_data.html`. The numeric variables are hardcoded and picked up by the various languages, so @huey735 will have to change the values from there. This should solve the transifex problem, since the values in the `.yml` files are now the same for all languages.

 > I think the better work flow is to have the changes done to the English pages and strings_en.yml, merged so that Transifex can fetch the changes and then download the translations when they're done and merge them.

Since the translations to be made are very easy and will take only few minutes, i suggest to ask directly to the translators on slack and then implement their translations to this PR. Merging, pulling on transifex, waiting translators to submit their work and them push it here requires time and in this case is better to just go the manual way.

Also, how is bisq.io deployed? Directly from GitHub? if this is the case, merging and then waiting for translators on transifex should be out of question, since the website would have mising strings.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190829/6e72f524/attachment.html>

More information about the bisq-github mailing list