[bisq-network/bisq] [WIP] Traders chat (#3165)

[chimp1984]

Based on PR  #2871 from @sqrrm.

I share the PR so that others can add optimisations for design and wording.

Open questions:
- Do we need a flag in the settings to allow the user to not receive chat messages? Would require that the peer gets that information as well which is a bit of an effort. Maybe we can keep that for a later version if needed at all.
- Do we need a popup or "news" badge to make sure users will find the new feature? I guess it is obvious enough, specially if you get a message.
- Do we want a badge icon showing new messages if the selected screen is not pending trades?
- Do we want to send mobile notifications?

I think all the above is not needed, at least not for a first release. But some UI beautification (@ripcurlx) and better wording (@m52go) would be nice...

<img width="1423" alt="Screen Shot 2019-08-30 at 01 13 20" src="https://user-images.githubusercontent.com/54558767/63982606-6301b300-cac3-11e9-8ebd-1c8c6c131e5c.png">

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3165

-- Commit Summary --

  * Refactor Chat out of TraderDisputeView
  * Send acks when capability found
  * Separate most of Chat and arbitration
  * Move close ticket button creation to arbitration
  * Handle Chat message subscription inside Chat
  * Add ChatManager
  * Add trader chat
  * Make attachments optional
  * Test trade chat UI
  * Add comments on BSQ trade fee calculation
  * Change message box aid
  * Add basic chat UI
  * Merge branch 'master_upstream' into sq-add-trader-chat
  * Fix merge issues
  * Update string
  * Add comments, cleanup, fix wrong param name
  * Show chat in popup instead of tab (WIP)
  * Add close handler to popup
  * Merge branch 'master_upstream' into sq-add-trader-chat
  * Apply changes from master
  * Add missing allServicesInitialized check
  * Add wasDisplayed field to chatMsg
  * Add onAllServicesInitialized call, rename method
  * Add missing setWasDisplayed
  * Add badge for num new chat msg
  * Fix wrong pubkey
  * Add chat rules system msg; cleanups
  * Handle nullables

-- File Changes --

    M common/src/main/java/bisq/common/storage/FileManager.java (4)
    M common/src/main/proto/pb.proto (7)
    A core/src/main/java/bisq/core/arbitration/DisputeChatSession.java (177)
    M core/src/main/java/bisq/core/arbitration/DisputeManager.java (285)
    M core/src/main/java/bisq/core/arbitration/messages/DisputeCommunicationMessage.java (72)
    A core/src/main/java/bisq/core/chat/ChatManager.java (219)
    A core/src/main/java/bisq/core/chat/ChatSession.java (66)
    M core/src/main/java/bisq/core/dao/governance/param/Param.java (2)
    M core/src/main/java/bisq/core/trade/TradableList.java (4)
    M core/src/main/java/bisq/core/trade/Trade.java (26)
    A core/src/main/java/bisq/core/trade/TradeChatSession.java (176)
    M core/src/main/java/bisq/core/trade/TradeManager.java (16)
    M core/src/main/java/bisq/core/util/CoinUtil.java (1)
    M core/src/main/resources/i18n/displayStrings.properties (14)
    A desktop/src/main/java/bisq/desktop/main/Chat/Chat.java (765)
    M desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java (619)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/BuyerSubView.java (1)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.fxml (1)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (202)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3165.patch
https://github.com/bisq-network/bisq/pull/3165.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3165
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190829/0d14db41/attachment-0001.html>