[bisq-network/bisq] Validate phone numbers (#3149)

[Christoph Atteneder]

> Q1: Should I tag Validators that will 'die' in this PR as @deprecated?

> Q2: Should I remove unused Validators from the project, and tweak constructor signatures, etc., that include them?

Maybe just extend the PhoneNumberValidator in e.g. SwishValidator so there is less code change to be reviewed and if in the future some specific checks have to be added it is quicker to do so

> Q3: In the country agnostic payment methods, should I include a country selector in the payment method forms that `((require phone number) && (require country code for phone validation))`?
> 
> Q4: Should those new country selectors include only countries that are valid for a particular payment method?

If we want to use the validator for those payment methods it will be necessary to add the country selectors. I think it would be fine to move Q3 and Q4 into a new PR as it will take more testing code changes than just add the PhoneNumberValidation. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3149#issuecomment-526561543
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190830/2b9d2b62/attachment.html>